Skip to content

feat: configure edge function at route level #12323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

kylesloper
Copy link

@kylesloper kylesloper commented Jun 10, 2024

Unlike the Vercel adapter, the Netlify Adapter currently doesn't support route level config or specifying an edge function at the route level. (e.g) all routes are normal lambda functions but a specific route is rendered on the edge using export config .

I've used this internally for a while but thought it may be helpful to the wider community.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 4494428

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino added the feature / enhancement New feature or request label Oct 10, 2024
@eltigerchino eltigerchino changed the title feat: Configure edge function at route level for Netlify Adapter feat: configure edge function at route level Oct 10, 2024
@eltigerchino eltigerchino added the feature / enhancement New feature or request label Oct 10, 2024
@eltigerchino
Copy link
Member

eltigerchino commented Oct 10, 2024

@kylesloper since you've been using this, has this allowed you to split your routes into both serverless and edge? Currently, the adapter has the limitation of only accepting the split config or edge config but not both. This PR would essentially be removing that limitation too, no?

I've tried uploading a build to Netlify and it only detects a single function although I have two routes, one configured with edge. I'm afraid we'd need to first solve the aforementioned issue and enable edge functions and split config to work with the adapter.

@eltigerchino eltigerchino removed the request for review from benmccann October 10, 2024 07:37
@eltigerchino eltigerchino marked this pull request as draft October 10, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants