Skip to content

fix(eslint-plugin-svelte): Replace isSpaceBetweenTokens with isSpaceBetween#1516

Open
kevin-easygo wants to merge 1 commit intosveltejs:mainfrom
kevin-easygo:fix/eslint-10-sourcecode-methods
Open

fix(eslint-plugin-svelte): Replace isSpaceBetweenTokens with isSpaceBetween#1516
kevin-easygo wants to merge 1 commit intosveltejs:mainfrom
kevin-easygo:fix/eslint-10-sourcecode-methods

Conversation

@kevin-easygo
Copy link
Copy Markdown

This PR removes usage of isSpaceBetweenToken and replaces it with isSpaceBetween, since the former has been deprecated.

Solves #1515.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 14, 2026

⚠️ No Changeset found

Latest commit: 396c88f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

});

const noExtraSpace = source.isSpaceBetweenTokens(
const noExtraSpace = source.isSpaceBetween(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case that confirms this change has resolved the issue?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! The method has only been deprecated in ESLint 10, while the repo relies on eslint@~9.39.4.
What's the best way to test this without changing the dependency list?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI runs with ESLint v8/v9/v10 versions.

Therefore, I believe we can verify whether the issue has been resolved simply by adding the code you provided in the issue as a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants