feat(prefer-svelte-reactivity): ignoring encapsulated local variables by default - #1287
Draft
marekdedic wants to merge 8 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 1bb806a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
27 times, most recently
from
August 6, 2025 19:19
e353727 to
be6878b
Compare
marekdedic
marked this pull request as ready for review
August 6, 2025 19:21
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
8 times, most recently
from
August 8, 2025 09:39
9354900 to
d853d1b
Compare
ota-meshi
requested changes
Sep 3, 2025
ota-meshi
left a comment
ota-meshi
left a comment
Member
There was a problem hiding this comment.
Sorry for the late reply.
I think this PR contains changes for multiple purposes.
Could you split it into several PRs?
I think at least the following two should be split:
- Add the
ignoreEncapsulatedLocalVariablesoption - Tracking private properties
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
from
September 4, 2025 22:22
3466ad0 to
433cde8
Compare
Contributor
Author
|
Ok, I've started in #1326 but I'm afraid the PRs will have to be (mostly) sequential because otherwise there'll just be too many conflicts. |
marekdedic
marked this pull request as draft
September 4, 2025 23:34
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
2 times, most recently
from
September 21, 2025 08:55
fe64eed to
ccfd154
Compare
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
from
September 23, 2025 14:47
ccfd154 to
7f2fbb6
Compare
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
2 times, most recently
from
November 1, 2025 08:05
d40595a to
cab6f59
Compare
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
from
December 13, 2025 10:02
cab6f59 to
22f2a58
Compare
marekdedic
force-pushed
the
prefere-svelte-reactivity-ignore-encapsulated-local-variables
branch
from
April 16, 2026 13:16
22f2a58 to
1bb806a
Compare
Contributor
|
@marekdedic Is there any plan on updating/fixing this? Any constructor call within a non-reactive closure triggers false positives. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1271