-
-
Notifications
You must be signed in to change notification settings - Fork 66
feat(cli): Create & add one go #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kizivat
wants to merge
28
commits into
sveltejs:main
Choose a base branch
from
kizivat:create-add-one-go
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
5f4e721
add --add option to create & extract question prompting for addons
kizivat ebe1d46
Merge branch 'main' into create-add-one-go
kizivat 0848b54
rmv log
jycouet 2b9a0a2
hisplay help after conflicts
jycouet a4a6e30
Merge branch 'main' of github.com:sveltejs/cli into pr/kizivat/695
jycouet b596a97
update // TODO_ONE
jycouet 1630915
Merge branch 'main' into create-add-one-go
jycouet e93518c
Merge branch 'main' of github.com:sveltejs/cli into create-add-one-go
jycouet 82ee099
Merge branch 'main' of github.com:sveltejs/cli into create-add-one-go
jycouet b93269c
Merge branch 'main' of github.com:sveltejs/cli into create-add-one-go
jycouet c3b1145
createVirtualWorkspace first step
jycouet 1695e31
args
jycouet 4c425ad
easier to read
jycouet e66e861
feat(cli): `npx sv create` now supports a new argument `--add`
jycouet 8ff8c17
Merge branch 'main' of github.com:sveltejs/cli into create-add-one-go
jycouet a981ca2
the only easy stuff
jycouet f43b4f1
check
jycouet d9d39fa
refacto workspace & workspaceOptions
jycouet 7b502a8
lint & check
jycouet 7227e16
fixing mcp issue
jycouet 1526721
fix packagemanager issue
jycouet 2fbfe0b
linting power
jycouet 3614d0a
draft show args
jycouet ca855e2
add args
jycouet 5a01ce2
better error escape
jycouet c78f68c
okay delay some questions
jycouet e63ec9b
show args changeset
jycouet 8a0608b
also in add
jycouet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'sv': patch | ||
| --- | ||
|
|
||
| feat(cli): `npx sv create` now supports a new argument `--add` to add add-ons to the project in the same command. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'sv': patch | ||
| --- | ||
|
|
||
| feat(cli): show args used so that you can run the cli without any prompt next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself: one of the changsets (or both) should probably be minor, as we are changing quite a lot under the hood and this is imo a huge milestone. And I'm pretty sure we can also find a technical reason for that 😆