fix(prettier): skip non-JSON prettierrc config #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the project already has a `.prettierrc` which is YAML, we will currently throw an uncaught exception trying to parse it as JSON. This change means we will skip such files and only try to mutate JSON configs.
🦋 Changeset detectedLatest commit: 55f45b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
if you can word the warning message any better, let me know or feel free to push to this branch basically, if you have an existing |
benmccann
reviewed
Apr 7, 2025
Co-authored-by: Ben McCann <[email protected]>
commit: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the project already has a
.prettierrcwhich is YAML, we will currently throw an uncaught exception trying to parse it as JSON.This change means we will skip such files and only try to mutate JSON configs.