perf: replace setTimeout drag with optimised RAF split engine#22
Open
SumitRajpal wants to merge 1 commit intosvar-widgets:mainfrom
Open
perf: replace setTimeout drag with optimised RAF split engine#22SumitRajpal wants to merge 1 commit intosvar-widgets:mainfrom
SumitRajpal wants to merge 1 commit intosvar-widgets:mainfrom
Conversation
a911c3e to
716cc09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the original
setTimeout(100ms)drag implementation with a fullyoptimised RAF-based split engine, delivering significantly smoother resizing
across all devices.
What changed
New files
src/components/splitEngine/useDragEngine.js— standalone drag engine hooksrc/components/splitEngine/clamp.js— pure arithmetic utilityModified
src/components/Resizer.jsx— wired to new engine, DEV-only FPS overlaysrc/components/Layout.jsx— passeslayoutRefascontainerRefto ResizerOptimisations applied
onMove→ React reconcile drops from 60/sec to 1 (on drop only). DOM writes go direct to GPU thread.dragobject never set tonull— V8 holds one IC forever, no deopt.setPointerCapturepointermoveat 60fps.getCoalescedEvents()engineRef.handleMovehas zero deps and is never re-JIT'd by V8.DEV-only FPS overlay
A fixed bottom-right FPS counter is shown during active drag in development
mode only (
import.meta.env.DEV). Stripped completely from production builds.Test plan
chart/grid