-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default value system and group names. #76
Conversation
…t even the normal version of DAGMC uses that naming scheme now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there was one substantive change buried in all the whitespace noise, and I think it's missing a matching deletion of the closing brace.
if(Gopt.uwuw_names){ | ||
bool mass_density = false; | ||
bool mass_density = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation seems inconsistent.
Also, I think the closing brace from this now-deleted if statement is still floating around somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah that deletion was a mistake. Thanks! Just replaced that line and fixed the indentation.
Thanks for the rapid review! Just took care of that mistakenly removed like. And apologies for the whitespace noise, my editor is set to aggressively remove trailing whitespace. |
BTW - who actually uses this anymore? Was this prompted by user interest? |
Are you referring to mcnp2cad as a whole or specifically the CLI version? |
This PR makes the default values found in the CLI client part of the
Gopt
struct part of it's default state upon creation. It also changes the default value for theuwuw_names
option fromfalse
totrue
-- there aren't any workflows I'm aware of that support the old naming scheme any more.