Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default value system and group names. #76

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

pshriwise
Copy link
Member

This PR makes the default values found in the CLI client part of the Gopt struct part of it's default state upon creation. It also changes the default value for the uwuw_names option from false to true -- there aren't any workflows I'm aware of that support the old naming scheme any more.

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there was one substantive change buried in all the whitespace noise, and I think it's missing a matching deletion of the closing brace.

if(Gopt.uwuw_names){
bool mass_density = false;
bool mass_density = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation seems inconsistent.

Also, I think the closing brace from this now-deleted if statement is still floating around somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah that deletion was a mistake. Thanks! Just replaced that line and fixed the indentation.

@pshriwise
Copy link
Member Author

It looks like there was one substantive change buried in all the whitespace noise, and I think it's missing a matching deletion of the closing brace.

Thanks for the rapid review! Just took care of that mistakenly removed like. And apologies for the whitespace noise, my editor is set to aggressively remove trailing whitespace.

@gonuke
Copy link
Member

gonuke commented Apr 10, 2024

BTW - who actually uses this anymore? Was this prompted by user interest?

@gonuke gonuke merged commit 3e35fed into svalinn:master Apr 10, 2024
@pshriwise
Copy link
Member Author

pshriwise commented Apr 10, 2024

Are you referring to mcnp2cad as a whole or specifically the CLI version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants