Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dockerfile for libeigen3 #67

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Update dockerfile for libeigen3 #67

merged 1 commit into from
Sep 11, 2019

Conversation

veeshy
Copy link
Contributor

@veeshy veeshy commented Sep 9, 2019

Assumes armadillo is indeed gone and install libeigen3 in its place for the docker file

@veeshy
Update dockerfile
993bf60 
Removing Armadillo in favor of libeigen3.
@gonuke
Copy link
Member

gonuke commented Sep 9, 2019

Good catch @veeshy ! I'm going to ping @pshriwise to double check that this doesn't pose any problems

@gonuke gonuke requested a review from pshriwise September 9, 2019 22:53
@pshriwise
Copy link
Member

Yes, @veeshy, thank you! Currently testing the new file.

pshriwise
pshriwise reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dockerfile built just fine for me (once I stopped accidentally cutting its internet connection with my VPN). Thanks @veeshy!

@pshriwise pshriwise merged commit 3bb6833 into svalinn:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshriwise pshriwise pshriwise left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veeshy @gonuke @pshriwise