Commit to new modular architecture #53
Conversation
…c code. Started to include case-by-case type reduction for more friendly CAD types if they are geometrically equivalent.
…th delta no matter what.
… code from CMakeLists.txt.
|
It would be great to get this reviewed and merged.... I essence this is the only branch we are using anyway, and merging it will just make our documentation a little easier |
| #include <string> | ||
| #include <cmath> |
There was a problem hiding this comment.
Do all of these need to go in the headers or can we include them in the appropriate .cpp files to avoid additional overhead in translation units?
There was a problem hiding this comment.
Definitely a good idea to make this change....
There was a problem hiding this comment.
I'll make an issue as a reminder about this.
|
Thanks for the merge @pshriwise and bringing us formally into the new era of mcnp2cad! Are there now some additional fixes that are waiting in other branches? E.g. |
|
Yeah... I suppose there are. I'm kinda confused though. There is a fix for lattice translations in |
This PR replaces #33 - the code is the same set of commits with one additional commit for the README file.
This branch has been the de facto development branch for over a year. It is not perfect, but it makes sense to commit to it going forward and then make improvements.