-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding check for standalone project. #43
Conversation
Hmmm... surprised that this was necessary.... |
doesn't it find the library when being built as part of the plugin? |
Not if it hasn't been built yet. |
What if, instead, we tweaked the DAGMC-Trelis |
I looked into that, but most of the solutions were fairly complicated and fragile, being outside of CMake's intended use of One other solution I looked at was the https://cmake.org/cmake/help/v3.0/module/ExternalProject.html |
If line 82 is moved to line 140 in the plugin's CMakeList.txt file, won't this ensure that iGeom has been built? |
Sadly no. CMake is going to traverse all subdirectories and configure them before building any of the targets. (I did try this to make sure though.) |
boo! OK - but don't we eventually need to |
We build the |
yeah... OK - work for us now, but if someone else wants to connect |
This PR adds a check to determine if mcnp2cad is being built as standalone or as part of another project (the DAGMC-Trelis plugin). This should fix the problem we're seeing with having to run make and cmake more than once when building the importer.