Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sns gq updates #31

Closed
wants to merge 2 commits into from
Closed

Sns gq updates #31

wants to merge 2 commits into from

Conversation

pshriwise
Copy link
Member

@pshriwise pshriwise commented Nov 1, 2016

These updates are a result of our experience translating a native SNS model:

  • Adding support for GQ ellipsoid
  • Adding case-by-case reduction of GQ types to more CAD-friendly types if they are geometrically equivalent or near a transition. This is usually based on a near-zero coefficient.

With this PR the GQ types now supported are ELLIPSOID, ELLIPTIC_CONE, and ELLIPTIC_CYL

@gonuke
Copy link
Member

gonuke commented Nov 2, 2016

Do we have any tests for this? I know that

  • mcnp2cad is sorely lacking for tests,
  • we've discussed how to do this before
  • it's hard to do
  • I don't have a huge appetite for comprehensive testing at this time

but, I have know way to judge this addition...
Maybe @makeclean should take a look.

@pshriwise
Copy link
Member Author

Sadly no we don't have any tests for these changes. They have shown to be effective in reducing GQ types to something more CAD-friendly in a lot of cases with near-zero second order coefficients or RHS values. The beginning of this new workflow made translating two relatively complex models from Steve Liley (ESS and ISIS) with 20+ GQs. Though I will admit that, while better, this workflow still relies on tolerance values to get the right answer.

pshriwise added 2 commits March 23, 2017 09:09
…c code. Started to include case-by-case type reduction for more friendly CAD types if they are geometrically equivalent.
@gonuke
Copy link
Member

gonuke commented Apr 28, 2017

This appears to have been merged in other places during swapping between repos.

@gonuke gonuke closed this Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants