Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS build script & Github Action for Trelis 17.1 and Cubit 2020.2 #86

Merged
merged 94 commits into from
May 25, 2021

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Feb 24, 2021

This builds on top of #84 , review after merge.
This also relies on svalinn/mcnp2cad#73

This includes:

  • build script to build the plugin on MacOS
  • GItHub Action to build the plugin on MacOS for Trelis17.1 and Cubit 2020.2

run: |
cd ${PLUGIN_ABS_PATH}/Trelis-plugin
rm -rf mcnp2cad
git clone https://github.com/bam241/mcnp2cad -b mac_build
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be changed when svalinn/mcnp2cad#73, gets merged.

mkdir -pv bld
cd bld
cmake .. $CMAKE_ADDITIONAL_FLAG \
-DUPDATE_SUBMODULES=OFF \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be changed when svalinn/mcnp2cad#73, gets merged.

@bam241
Copy link
Member Author

bam241 commented Feb 24, 2021

this works [email protected] added a new PR depedency: svalinn/DAGMC#728

we could avoid svalinn/DAGMC#728 and limit hdf5 version to 1.10.7

@bam241
Copy link
Member Author

bam241 commented Feb 25, 2021

getting the following error when trying to load Cubit2020.2 plugin built with the GitHub action:

ERROR: <stdin>, line 0. Error loading /Applications/Coreform-Cubit-2020.2.app/Contents/MacOS/plugins/libsvalinn_plugin.so:
ERROR: <stdin>, line 0. 
Finished Command: undo on

@bam241
Copy link
Member Author

bam241 commented Feb 25, 2021

installing brew install eigen hdf5 using brew solves it.

I guess we have to ship some of those within the package

@bam241
Copy link
Member Author

bam241 commented Feb 25, 2021

it was actually slightly more complicated than that:
one of the hdf5 deps was required not hdf5 itself brew install szip

@bam241
Copy link
Member Author

bam241 commented Feb 25, 2021

I fixed it adding /libsz.2.dylib in the plugin and running :
sudo install_name_tool -change /usr/local/opt/szip/lib/libsz.2.dylib @rpath//libsz.2.dylib libsvalinn_plugin.so

@bam241
Copy link
Member Author

bam241 commented Feb 25, 2021

inclusion of szlib fixed it.

@gonuke
Copy link
Member

gonuke commented Mar 2, 2021

I plan to review this after we merge #84 to focus on the Mac parts...

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given my contribution, I probably shouldn't merge this.... but I approve

@gonuke
Copy link
Member

gonuke commented Mar 27, 2021

I think this is ready to go @pshriwise

@bam241
Copy link
Member Author

bam241 commented Mar 30, 2021

as a reminder this depends on svalinn/mcnp2cad#73

@bam241
Copy link
Member Author

bam241 commented Apr 7, 2021

@pshriwise when you have time could you take a look here ?

Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks pretty good to me. There are just some outstanding issues that @gonuke raised I think:

  • looking into merging the Linux and Mac workflow files
  • getting diff's of the Cubit CMake files from the SDK and look into patching those instead of including the modified files

Also if we can communicate the changes we needed to make to the CMake files Coreform that would probably be good.

@bam241 bam241 mentioned this pull request May 25, 2021
Copy link
Member

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bam241! On to the next PR I suppose 😃

@pshriwise pshriwise merged commit ee7cc91 into develop May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants