-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS build script & Github Action for Trelis 17.1 and Cubit 2020.2 #86
Conversation
.github/workflows/mac.yml
Outdated
run: | | ||
cd ${PLUGIN_ABS_PATH}/Trelis-plugin | ||
rm -rf mcnp2cad | ||
git clone https://github.com/bam241/mcnp2cad -b mac_build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be changed when svalinn/mcnp2cad#73, gets merged.
.github/workflows/mac.yml
Outdated
mkdir -pv bld | ||
cd bld | ||
cmake .. $CMAKE_ADDITIONAL_FLAG \ | ||
-DUPDATE_SUBMODULES=OFF \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be changed when svalinn/mcnp2cad#73, gets merged.
this works [email protected] added a new PR depedency: svalinn/DAGMC#728 we could avoid svalinn/DAGMC#728 and limit hdf5 version to |
getting the following error when trying to load Cubit2020.2 plugin built with the GitHub action:
|
installing I guess we have to ship some of those within the package |
it was actually slightly more complicated than that: |
I fixed it adding |
inclusion of szlib fixed it. |
I plan to review this after we merge #84 to focus on the Mac parts... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given my contribution, I probably shouldn't merge this.... but I approve
I think this is ready to go @pshriwise |
Co-authored-by: Paul Wilson <[email protected]>
as a reminder this depends on svalinn/mcnp2cad#73 |
@pshriwise when you have time could you take a look here ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks pretty good to me. There are just some outstanding issues that @gonuke raised I think:
- looking into merging the Linux and Mac workflow files
- getting diff's of the Cubit CMake files from the SDK and look into patching those instead of including the modified files
Also if we can communicate the changes we needed to make to the CMake files Coreform that would probably be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bam241! On to the next PR I suppose 😃
This builds on top of #84 , review after merge.
This also relies on svalinn/mcnp2cad#73
This includes: