Set C++11 as C++ Standard #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems, cmake assumes by default the C++17 standard for compilation. However, the dynamic exception specifications are not allowed in the C++17 standard (and deprecated since C++11). The scope of the commit is to set the C++11 standard in the CMakeLists.txt file.
|
@giovanni-mariano thanks for doing this. This will help make the code more robust. Long term though I think modernizing is the solution. @gonuke should we open an issue to remove these specifications, and in general move to a newer C++ version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, cmake assumes by default the C++17 standard for compilation. However, the dynamic exception specifications are not allowed in the C++17 standard (and deprecated since C++11).
The scope of the commit is to set the C++11 standard in the CMakeLists.txt file.