Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some stuff #31

Closed
wants to merge 2 commits into from
Closed

Some stuff #31

wants to merge 2 commits into from

Conversation

Digital39999
Copy link
Contributor

@Digital39999 Digital39999 commented May 27, 2024

This pull request resolves Scrolling on discover page (with a catch), adds option to disable searching for movies if you're not logged in and adds option to disable any new registrations at all.

@sussy-code
Copy link
Collaborator

sussy-code commented May 28, 2024

You have completely changed my website, I don't want this search registration thing. However, I have been looking for a fix for the shitty scrolling on Discover page, your fix doesn't work and changes the look of the discover page (looks very unpleasing after commit). Taking these factors into considration I will not merge this pull request without the completion of the following:

  • Remove disable registrations & disable search when logged out
  • Restore Discover page to its previous look
  • Add compatibility for touchpads

@Digital39999
Copy link
Contributor Author

Digital39999 commented May 28, 2024

With all respect, I don't see how I changed the website in any way, and further more its not even actually your website but copy of original movie-web. I have just added something that people who are mostly selfhosting this for private use will find useful, which is literally the case, not everyone is super tech nerd to setup passwords and what not to access the actual page, and most then forget the password to it, don't want the option? Fine, don't toggle it on. For the discover page, how have I changed it? By adding top light thing? To just make it look like the rest of such pages? Like 404 and homepage, you don't really make sense, only thing different is removed light that makes whole website bug out on a simple task of scrolling. And you saying that "you don't want", then what is the point in this being open sourced if people can't adapt it for others without literally not visually changing it in a drastic way, that's selfish.

@Digital39999
Copy link
Contributor Author

Literally almost 0 difference, objectively 1st is better looking.

@sussy-code
Copy link
Collaborator

Brother, i mess with the lightbar on discover page but everything else is dooty. just look at this video, if you want this merged please remove the specified things in the check boxes above. Also do the below items:

  • fix scrolling not working with mouse wheel on discover page
  • keep lightbar in its place on discover page

@Digital39999
Copy link
Contributor Author

So basically no points to argument mine as to why to keep registration stuff, great. What video?

@sussy-code
Copy link
Collaborator

oh i forgot the vid i guess🤷‍♂️ i am not gonna argue you over a codebase i control and i don't want the registration thing.

@Digital39999
Copy link
Contributor Author

Sure, we'll see.

@sussy-code
Copy link
Collaborator

wot?

@EthanQuarry
Copy link

Oh shit, it's going down

@sussy-code
Copy link
Collaborator

fr bro like i dont wanna add your shitty registration wall 💀

@sussy-code sussy-code closed this May 28, 2024
@EthanQuarry
Copy link

I will say the UI is beautiful but the UX lowkey stinks. Is it fine if I update some padding and shi, maybe add some skeleton loading states cuz it looks a lil goofy when I boot it up with friends (other than that I love it so much)

@sussy-code
Copy link
Collaborator

Yes i would love that sounds very nice please open a pr i would love to take a look, also join discord so i can make you a contributor

@Digital39999
Copy link
Contributor Author

fr bro like i dont wanna add your shitty registration wall 💀

I seriously don't get what's so wrong with it that you're so against.

@sussy-code
Copy link
Collaborator

idk why you think we want this in our code base just because you want it doesn't mean everyone does. image

@Digital39999
Copy link
Contributor Author

Digital39999 commented May 29, 2024

But then again only because you and 10 people don't want, doesn't mean whole world doesn't, like imo its just like let it be if some will find it useful.

@sussy-code
Copy link
Collaborator

bro just give up the great thing about open-source is that u can fork it and make your own repository

@Digital39999
Copy link
Contributor Author

Doesn't really work that way if i want to keep it up to date.

image

@JorrinKievit
Copy link
Contributor

it kinda does work that way

@sussy-code
This comment was marked as a violation of GitHub Acceptable Use Policies
@sussy-code sussy-code locked as too heated and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants