feat: dynamically inferred core types #995
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepjyoti30-st
force-pushed
the
feat/dynamically-inferred-core-types
branch
from
8af3ebf to
8a70534
Compare
|
📝 Documentation updates detected! You can review documentation updates here |
…ertokens:supertokens/supertokens-node into feat/dynamically-inferred-core-types
porcellus
requested changes
May 15, 2025
| { | ||
| userId: input.userId, | ||
| userIdType: input.userIdType, | ||
| externalUserIdInfo: input.externalUserIdInfo, | ||
| externalUserIdInfo: input.externalUserIdInfo || null, |
There was a problem hiding this comment.
In the API spec we define the possible types for externalUserIdInfo to be string | null but the SDK defines them as string | undefined. Do you reckon I change the SDK type definition instead? Or the API spec?
There was a problem hiding this comment.
@sattvikc what effect does each option have? null clears the mapping, right?
porcellus
requested changes
May 16, 2025
lib/ts/core/versions/5.3/schema.d.ts
Outdated
| @@ -3,6 +3,11 @@ | |||
| // @ts-nocheck | |||
| // @ts-nocheck | |||
| // @ts-nocheck | |||
| // @ts-nocheck | |||
There was a problem hiding this comment.
Why is this added so many times?
| { | ||
| userId: input.userId, | ||
| userIdType: input.userIdType, | ||
| externalUserIdInfo: input.externalUserIdInfo, | ||
| externalUserIdInfo: input.externalUserIdInfo || null, |
There was a problem hiding this comment.
@sattvikc what effect does each option have? null clears the mapping, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR adds support for inferring the querier request body and response body types based on the path entered. It uses the core driver interface spec file to achieve this.
There is a script that generates the updated schema and can be run with the following command, whenever necessary (i.e. whenever the API spec is updated):
Related issues
Test Plan
All tests should pass
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).exportsinpackage.json