[feature] Create/update/remove domain permission subscriptions #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Ensure URI is set. | ||
| if form.URI == nil { | ||
| const errText = "uri must be set" |
| // Allocate return slice (will be at most len permSubIDs). | ||
| permSubs := make([]*gtsmodel.DomainPermissionSubscription, 0, len(permSubIDs)) | ||
| for _, id := range permSubIDs { | ||
| permSub, err := d.GetDomainPermissionSubscriptionByID(ctx, id) |
There was a problem hiding this comment.
given that domain subscriptions encourage people to use the domain permission system more (so this endpoint will be called more often), do you think this is worth writing an optimized GetDomainPermissionSubscriptionsByIDs() function?
There was a problem hiding this comment.
It might be yeah... if it's alright with you I'd rather do this as a separate chore PR though.
| // Allocate return slice (will be at most len permSubIDs). | ||
| permSubs := make([]*gtsmodel.DomainPermissionSubscription, 0, len(permSubIDs)) | ||
| for _, id := range permSubIDs { | ||
| permSub, err := d.GetDomainPermissionSubscriptionByID(ctx, id) |
internal/db/bundb/migrations/20241022153016_domain_permission_subscriptions.go
Show resolved
Hide resolved
internal/db/bundb/migrations/20241022153016_domain_permission_subscriptions.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds database functions and frontend + api bits for creating, viewing, updating, and removing domain permission subscriptions. Currently the domain permission subscriptions aren't actually activated, this is to come in the next PR.
Documentation + tests and all that jazz to follow, also in a separate PR, to keep things manageable.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]->[x]If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...andgolangci-lint run.