Repository navigation
feat(viewer): 连线流动默认开启 - #18
Merged
Merged
Conversation
#16 把连线流动默认关掉,理由是静止的虚线会被读成"推断"记法;同一改动已让流动层只在运行时才绘制,这个顾虑不再成立,且关闭并非为了省生成时间或 token。 - 开关初始值与"重置"后的状态都改回开启;减弱动效偏好仍优先,开启该偏好时开关禁用、不流动 - viewer-development.md 去掉"默认关"的说明 - browser-interactions.mjs 的流动检查改回默认开:初始有流动层、关闭后移除、重置回到开启;重置后的断言先等重渲染再取值 - 重新构建 viewer-dist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了什么
查看器里「连线流动」开关默认由关改为开。
main.jsx、useViewerController.js:开关初始值与「重置」后的状态都改回开启viewer-development.md:去掉「默认关」的说明browser-interactions.mjs:流动检查改回默认开(初始有流动层、关闭后移除、重置回到开启);重置后的断言先等重渲染再取值viewer-dist/index.html为什么
#16 把它默认关掉,理由是静止的虚线会被读成「推断」记法;同一改动已让流动层只在运行时才绘制,这个顾虑不再成立。关闭并不是为了省生成时间或 token(流动层只是浏览器里的 CSS 动画,与生成无关)。
注意
验证
ambient-flow检查 9/9 通过