[SUBGRAPH] Add gasUsed property to all events
#1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bump subgraph package versions * add `gasUsed` property to all event entities * add tests for `gasUsed` property
0xdavinchee
requested review from
kasparkallas,
hellwolf and
a team
as code owners
kasparkallas
reviewed
Dec 6, 2022
packages/subgraph/src/utils.ts
Outdated
| if (event.receipt) { | ||
| // @note if we don't cast event.receipt as ethereum.TransactionReceipt, | ||
| // we get a compile error because it thinks event.receipt is: | ||
| // ethereum.TransactionReceipt | null |
There was a problem hiding this comment.
Normally TS should be able to infer the correct type with this logic:
const receipt = event.receipt;
if (receipt) {
entity.set("gasUsed", Value.fromBigInt(receipt.gasUsed));
} else {
entity.set("gasUsed", Value.fromBigInt(BIG_INT_ZERO));
}There was a problem hiding this comment.
yeah I think someone from their side suggested this too, will make this change 👍🏼
There was a problem hiding this comment.
Remove the comment too.
kasparkallas
reviewed
Dec 6, 2022
packages/subgraph/src/utils.ts
Outdated
| const receipt = event.receipt as ethereum.TransactionReceipt; | ||
| entity.set("gasUsed", Value.fromBigInt(receipt.gasUsed)); | ||
| } else { | ||
| entity.set("gasUsed", Value.fromBigInt(BIG_INT_ZERO)); |
There was a problem hiding this comment.
If the receipt should always be present (i.e. specified in the .yaml) then I'd prefer throwing in general.
There was a problem hiding this comment.
It's not going to throw ATM as the else-block is just removed? 😛
There was a problem hiding this comment.
it will throw because when we go and try to save the entity, this field is non-nullable
* remove casting * let it break if unable to get receipt
kasparkallas
approved these changes
Dec 6, 2022
XKCD Comic RelifLink: https://xkcd.com/1199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gasUsedproperty to all event entitiesgasUsedproperty