Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAG Template Set indexing_key variable from upstream listener #2

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mirkenstein
Copy link
Contributor

@mirkenstein mirkenstein commented Sep 4, 2024

RAG Template set indexing_key

  1. Set variable for indexing_key = upstream_listener.outputs everywhere to factor out dependencies across db backends and platforms.

Currently the hard coded _outputs__chunker does not work for different platforms.
In some instances it renders as _outputs.chunker

This is already implemented in the text vector search example

  1. Add working set of parameters to chunker model

Related Issues

NA

Checklist

  • Is this code covered by new or existing unit tests or integration tests?
  • Did you run make unit_testing and make integration-testing successfully?
  • Do new classes, functions, methods and parameters all have docstrings?
  • Were existing docstrings updated, if necessary?
  • Was external documentation updated, if necessary?

Additional Notes or Comments

@blythed
Copy link
Contributor

blythed commented Sep 4, 2024

Yes good point! Thank-you

@@ -79,7 +79,7 @@ won't be necessary.

CHUNK_SIZE = 200

@model(flatten=True, model_update_kwargs={})
@model(flatten=True, model_update_kwargs={'document_embedded': False})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer necessary in latest code-base since this option is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants