Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #814 #846

Merged
merged 14 commits into from
Jul 24, 2024
Merged

Fix #814 #846

merged 14 commits into from
Jul 24, 2024

Conversation

juancarlospaco
Copy link
Contributor

@juancarlospaco juancarlospaco commented Jul 3, 2024

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (819ba63) to head (6f0d0ac).
Report is 100 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #846       +/-   ##
===========================================
+ Coverage   43.97%   63.58%   +19.60%     
===========================================
  Files          13       13               
  Lines         332      346       +14     
===========================================
+ Hits          146      220       +74     
+ Misses        186      126       -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juancarlospaco juancarlospaco marked this pull request as ready for review July 4, 2024 18:27
@juancarlospaco juancarlospaco requested a review from a team as a code owner July 4, 2024 18:27
Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should follow how we are setting postgrest_client_timeout in other libraries. It should be passed through the constructor and not be added via a method through a private variable.

@juancarlospaco juancarlospaco marked this pull request as ready for review July 21, 2024 13:47
Copy link
Contributor

sourcery-ai bot commented Jul 21, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@silentworks silentworks merged commit c4fe829 into supabase:main Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httpx.ReadTimeout: timed out Supabase functions
4 participants