-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update typehint and add optional access_token to creat_client #656
Conversation
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.40 to 3.1.41. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](gitpython-developers/GitPython@3.1.40...3.1.41) --- updated-dependencies: - dependency-name: gitpython dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 44.17% 44.17%
=======================================
Files 13 13
Lines 326 326
=======================================
Hits 144 144
Misses 182 182 ☔ View full report in Codecov by Sentry. |
chore(deps-dev): bump gitpython from 3.1.40 to 3.1.41
supabase/_async/client.py
Outdated
AsyncRequestBuilder, | ||
) | ||
from postgrest import AsyncPostgrestClient, AsyncRequestBuilder | ||
from postgrest._async.request_builder import AsyncRPCFilterRequestBuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not imported from the postgrest
namespace itself? if its only available from the postgrest._async.request_builder
maybe we will need to also make it available from postgrest
otherwise I don't think unasync-cli
will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and it breaks, I'm updating the postgrest
package now to export AsyncRPCFilterRequestBuilder
from the main package and then this can be updated and merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for great works!
Hey @Atticuszz, not sure why you closed this as I think this is a good PR to get merged in. I've reopened it and will be merging it in soon. |
@silentworks also i add the optional access_token to creat_client |
@Atticuszz I need to investigate the |
Okay, good luck finding the problem soon!and i add explanation in #667 |
it's too old now,so closed it |
fix the rpc return typehint of async_client and add async typehint to client options
and add the optional access_token to creat_client
as for front end ,no need to pass refresh token every time,just access token,tokens should handled by supabase-js auth
as for auth by supabase-py,same to before