Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update typehint and add optional access_token to creat_client #656

Closed
wants to merge 8 commits into from
Closed

update typehint and add optional access_token to creat_client #656

wants to merge 8 commits into from

Conversation

AtticusZeller
Copy link

@AtticusZeller AtticusZeller commented Jan 7, 2024

fix the rpc return typehint of async_client and add async typehint to client options
and add the optional access_token to creat_client

as for front end ,no need to pass refresh token every time,just access token,tokens should handled by supabase-js auth
as for auth by supabase-py,same to before

Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.40 to 3.1.41.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.40...3.1.41)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@silentworks silentworks self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dcbd7b4) 44.17% compared to head (3973cf7) 44.17%.

❗ Current head 3973cf7 differs from pull request most recent head 7dfdcdd. Consider uploading reports for the commit 7dfdcdd to get more accurate results

Files Patch % Lines
supabase/_async/client.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   44.17%   44.17%           
=======================================
  Files          13       13           
  Lines         326      326           
=======================================
  Hits          144      144           
  Misses        182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AsyncRequestBuilder,
)
from postgrest import AsyncPostgrestClient, AsyncRequestBuilder
from postgrest._async.request_builder import AsyncRPCFilterRequestBuilder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not imported from the postgrest namespace itself? if its only available from the postgrest._async.request_builder maybe we will need to also make it available from postgrest otherwise I don't think unasync-cli will work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it breaks, I'm updating the postgrest package now to export AsyncRPCFilterRequestBuilder from the main package and then this can be updated and merged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for great works!

@silentworks
Copy link
Contributor

Hey @Atticuszz, not sure why you closed this as I think this is a good PR to get merged in. I've reopened it and will be merging it in soon.

@AtticusZeller AtticusZeller changed the title update typehint update typehint and add optional access_token to creat_client Jan 14, 2024
@AtticusZeller
Copy link
Author

AtticusZeller commented Jan 14, 2024

@silentworks also i add the optional access_token to creat_client
tested successed in with more tests in repo with my own supabase key

@silentworks
Copy link
Contributor

@Atticuszz I need to investigate the access_token issue a bit more first, lets not include it in the PR so I can get this merged in.

@AtticusZeller
Copy link
Author

AtticusZeller commented Jan 15, 2024

@Atticuszz I need to investigate the access_token issue a bit more first, lets not include it in the PR so I can get this merged in.

Okay, good luck finding the problem soon!and i add explanation in #667

@AtticusZeller
Copy link
Author

it's too old now,so closed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants