Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add flow_type to client options #610

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Add flow_type option to client options for gotrue-py

What is the current behavior?

Only supports implicit auth flow

What is the new behavior?

Can now select between pkce and implicit auth flow

Additional context

Add any other context or screenshots.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca79bbd) 69.54% compared to head (f1d8cba) 70.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   69.54%   70.00%   +0.45%     
==========================================
  Files           9        9              
  Lines         197      200       +3     
==========================================
+ Hits          137      140       +3     
  Misses         60       60              
Files Coverage Δ
supabase/client.py 68.42% <ø> (ø)
supabase/lib/auth_client.py 81.81% <100.00%> (ø)
supabase/lib/client_options.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silentworks silentworks merged commit 344850d into main Nov 1, 2023
@silentworks silentworks deleted the silentworks/pkce-support-client-options branch November 1, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants