fix: Apply RLS rules to Channel controller#758
Merged
filipecabaco merged 16 commits intomainfrom Jan 4, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
filipecabaco
force-pushed
the
fix/apply-rls-to-channel-endpoint
branch
from
597cb21 to
13d3917
Compare
abc3
reviewed
Dec 8, 2023
abc3
reviewed
Dec 8, 2023
abc3
reviewed
Dec 8, 2023
abc3
reviewed
Dec 8, 2023
filipecabaco
force-pushed
the
fix/apply-rls-to-channel-endpoint
branch
from
f6c5b11 to
9de45d5
Compare
josevalim
reviewed
Dec 27, 2023
josevalim
reviewed
Dec 27, 2023
josevalim
reviewed
Dec 27, 2023
josevalim
reviewed
Dec 27, 2023
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Hi @filipecabaco, comments added! 🎄
Member
Author
|
Awesome! thank you will tackle them 🙏 |
filipecabaco
force-pushed
the
fix/apply-rls-to-channel-endpoint
branch
from
a06530a to
ddfeab0
Compare
chasers
reviewed
Jan 3, 2024
| do $func_exists$ | ||
| begin if not exists(select * from pg_proc where proname = 'role') | ||
| then | ||
| create or replace function auth.uid() returns uuid as $function_def$ |
Contributor
There was a problem hiding this comment.
Why are we managing auth functions exactly again? These are not our fns.
Member
Author
There was a problem hiding this comment.
self hosting made easier basically. if we want to keep realtime as self deployable as possible we need to create them on our own if they are not present
chasers
reviewed
Jan 3, 2024
chasers
reviewed
Jan 3, 2024
chasers
reviewed
Jan 3, 2024
chasers
reviewed
Jan 3, 2024
chasers
approved these changes
Jan 4, 2024
filipecabaco
force-pushed
the
fix/apply-rls-to-channel-endpoint
branch
from
2589edd to
b7fe48d
Compare
Member
|
🎉 This PR is included in version 2.25.55 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Apply RLS rules to Channel controller