fix: terminate zombie migration runners #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@supabase/dashbit Could you take a look to see if this makes sense? |
|
@philss thanks for the feedback! Please let me know if you need any additional info to reproduce such behavior |
|
🎉 This PR is included in version 2.25.34 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While applying migrations to a tenant's database, I observed that
Ecto.Migration.Runnerdoes not stop when encountering errors. Upon brief inspection, I noticed that theEcto.Migratoronly stops the Agent if the migration succeeds. In the case of an error, the Migrator catches it and exits with anormalreason, which does not lead to the termination of the linked Runner process. As a result, this leads to memory leaks when Realtime continuously attempts to run migrations that encounter errorsAs a quick solution from our side, we could stop all runners that are linked only to
MigratorSupervisorafter a failure. Normally, they also have a link to the Migrator that initiated themScreen.Recording.2023-11-17.at.13.34.29.mov