fix - Set slot_name_suffix to avoid conflicts on deploys #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sets a default value for slot_name_suffix so we avoid issues during deployments Plus sets the SynHandler as conflict resolution for :syn on the Application.ex level
filipecabaco
force-pushed
the
fix/slot-name-suffix-default
branch
from
8f81a1c to
c3ed74b
Compare
abc3
reviewed
Oct 23, 2023
| setup do | ||
| slot_name_suffix = Application.get_env(:realtime, :slot_name_suffix) | ||
|
|
||
| on_exit(fn -> Application.put_env(:realtime, :slot_name_suffix, slot_name_suffix) end) |
There was a problem hiding this comment.
why does it need to put this key on the exit?
There was a problem hiding this comment.
resetting the env to be equal to what it was in the start since we're changing application setup
|
🎉 This PR is included in version 2.25.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Sets a default value for slot_name_suffix so we avoid issues during deployments
Plus sets the SynHandler as conflict resolution for :syn on the Application.ex level