This PR adds region and instance ID #1341
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature: Adds
region
andinstance_id
to logger metadata (#627)What is the current behavior?
This metadata is currently not included in logs, as described in issue #627.
What is the new behavior?
Adds
region
andinstance_id
metadata to the logger using values from the environment:This allows these fields to be available in log output for observability and debugging.
Additional context
I also considered adding a helper to make required env vars safer and more expressive:
Which would allow replacing direct
System.get_env/1
calls with:I also briefly considered defaulting to safe fallbacks in dev/test environments:
But I wasn't sure if that was necessary, or if it might obscure misconfigured environments. If preferred, I’m happy to incorporate either approach. 😊