Repository navigation
refactor(nix/cargo-pgrx): build cargo-pgrx by overriding upstream pkg - #2666
Merged
Merged
Conversation
Replace the vendored and outdated cargo-pgrx expression with an override of the upstream nixpkgs package, dropping the manual dependency wiring, custom check flags, and meta block. Remove the cargo-pgrx overlay and call the package set directly via callPackages in the package list. Using the overlay shadows the upstream package, and in addition just adds another layer of unneeded indirection.
Refs: MPG-1348 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs: MPG-1348 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Refs: MPG-1348 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Closure size: 73 -> 73 (2 paths added, 2 paths removed, delta +0, disk usage +0B).x86_64-linux: Closure size: 74 -> 74 (2 paths added, 2 paths removed, delta +0, disk usage +0B). |
brainrake
marked this pull request as ready for review
November 17, 2026 00:17
PostgreSQL Extension Dependency Analysis: PR #2666
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2666
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
mmlb
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the vendored cargo-pgrx expression with an override of the upstream nixpkgs package. This drops the manual dependency wiring and the meta block.
The crates.io workarounds (
fix-cargo.nix,registryDl,auditable = false) stay on top of the override.Built
psql_17/binon aarch64-darwin fromdevelopand from an earlier revision of this branch, before the latestdevelopmerge. The closure diff shows no version changes. The only differences inwrappers-0.4.4.dylibare the embedded build path, the Mach-O UUID, and the code signature hashes.Not checked:
psql_15,orioledb-17, Linux,nix flake check.Based on earlier work by Kranzes.
MPG-1348