Repository navigation
migrations: Clean up README.md and avoid unnecessary image builds - #2641
Merged
Merged
Conversation
PostgreSQL Extension Dependency Analysis: PR #2641
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2641
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
Package version diffCompares built package versions in legacyPackages between this PR and the tip of the base branch, per system. aarch64-linux: Baseline unavailable for `e2a536f2c`, version diff skipped (no successful merge queue run, or it expired).x86_64-linux: Baseline unavailable for `e2a536f2c`, version diff skipped (no successful merge queue run, or it expired). |
tkren
approved these changes
Nov 11, 2026
|
Found 1 test failure on Blacksmith runners: Failure
|
mmlb
force-pushed
the
push-kxotpmxouryo
branch
from
November 11, 2026 22:10
5d202fe to
77e2bd3
Compare
run-server.sh.in replaces PATH with only the binaries in TOOLS_PATH, and bash wasn't one of them. The pgsodium getkey script it uses (nix/tests/util/pgsodium_getkey.sh) is copied into the store as-is with a `#!/usr/bin/env bash` shebang, so `nix run .#start-server` failed with "env: bash: No such file or directory" and "FATAL: invalid secret key". Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Remove the `nix run github:...#dbmate-tool` examples. The tool builds the local `.` flake and needs a checkout, so the GitHub ref was ignored. Also note that new migration files must be `git add`ed before regenerating the schema, because the flake ignores untracked files. Assisted-by: Claude <noreply@anthropic.com>
There are a bunch of files in migrations directory and it wasn't obvious what they were for without reading a bunch of sources in the repo so I wanted to write something down. "Where migrations run" lists what uses the files in `db/` and "Other files in this directory" explains what `tests/` and `schema-<version>.sql` are for. Also reworded some content for better readability and fixed some links. I ended up cleaning up a few other bits of prose. Assisted-by: Claude <noreply@anthropic.com>
We only need migrations/db in the AMI/qemu source packages. No point adding the whole top level directory since unrelated changes will cause unnecessary ami / qemu builds. I noticed this when making changes to README.md and saw the AMIs being built.
mmlb
force-pushed
the
push-kxotpmxouryo
branch
from
November 11, 2026 22:16
77e2bd3 to
d6ee684
Compare
mmlb
enabled auto-merge
November 11, 2026 22:20
tkren
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
I changed start-postgres-server in #2636 to ignore callers
$PATHand use tools from nixpkgs but inadvertently droppedbashwhich is needed bynix/tests/util/pgsodium_getkey.sh's#!/usr/bin/envthatstart-postgres-serveruses.Also docs mentioned running
nix run github:supabase/postgres#dbmate-toolbut won't work any more without passing--flake-urldue to default flake url being..Modifying any files under
migrations/causes AMI/qemu rebuilds, even for markdown changes.What is the new behavior?
nix run .#start-serverworks again.Docs don't help the reader do not-recommended commands.
No unnecessary rebuilds from modifications to files images don't care about.