fix: vault grants post-upgrade #1606
Open
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+229
to
+236
| grant usage on schema vault to postgres with grant option; | ||
| grant select, delete, truncate, references on vault.secrets, vault.decrypted_secrets to postgres with grant option; | ||
| grant execute on function vault.create_secret, vault.update_secret, vault._crypto_aead_det_decrypt to postgres with grant option; | ||
|
|
||
| -- service_role used to be able to manage secrets in Vault <=0.2.8 because it had privileges to pgsodium functions | ||
| grant usage on schema vault to service_role; | ||
| grant select, delete on vault.secrets, vault.decrypted_secrets to service_role; | ||
| grant execute on function vault.create_secret, vault.update_secret, vault._crypto_aead_det_decrypt to service_role; |
There was a problem hiding this comment.
Can this change be covered by tests somehow?
There was a problem hiding this comment.
No, only through manual tests. We don’t have a test harness that covers upgrades.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to https://github.com/supabase/postgres/pull/1539/files.
The change has been applied for new & restored projects, but not post-upgrade.
Updated supabase/postgres migrations are not reapplied on post-upgrade, only on post-restore. So for the change to be applied on upgraded projects, we need to apply it on the post-upgrade script.