Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support encrypted values in config #3013

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 3, 2025

What kind of change does this PR introduce?

feature

What is the new behavior?

Follow dotenvx convention for encrypted secrets.

api_key = "encrypted:<base64_encoded>"

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 3, 2025 12:24
@coveralls
Copy link

coveralls commented Jan 3, 2025

Pull Request Test Coverage Report for Build 12631585346

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 67 of 71 (94.37%) changed or added relevant lines in 3 files are covered.
  • 40 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.04%) to 59.763%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/auth.go 4 5 80.0%
pkg/config/secret.go 54 55 98.18%
pkg/config/config.go 9 11 81.82%
Files with Coverage Reduction New Missed Lines %
pkg/storage/buckets.go 2 83.33%
internal/storage/rm/rm.go 2 89.53%
pkg/config/config.go 4 52.6%
pkg/cast/cast.go 5 75.76%
internal/gen/keys/keys.go 5 12.9%
internal/branches/get/get.go 22 0.0%
Totals Coverage Status
Change from base Build 12595878677: 0.04%
Covered Lines: 7725
Relevant Lines: 12926

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants