Skip to content

Fix: SAML SP metadata endpoint generates incorrect XML with IDP EntityID #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adityakk9031 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: SAML SP metadata endpoint generates incorrect XML with IDP EntityID #2313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions internal/api/saml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,23 @@ func (a *API) getSAMLServiceProvider(identityProvider *saml.EntityDescriptor, id

provider.AuthnNameIDFormat = saml.PersistentNameIDFormat

baseURL := *externalURL

// Set MetadataURL
metadataURL := baseURL
metadataURL.Path += "saml/metadata"
provider.MetadataURL = metadataURL

// Set AcsURL (Assertion Consumer Service)
acsURL := baseURL
acsURL.Path += "saml/acs"
provider.AcsURL = acsURL

// Set SloURL (Single Logout)
sloURL := baseURL
sloURL.Path += "saml/slo"
provider.SloURL = sloURL

return &provider
}

Expand Down