Skip to content

feat: add an API to run tasks outside of transactions #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cstockton
Copy link
Contributor

This also includes an example of using it inside of mail.go

This also includes an example of using it inside of mail.go
@cstockton cstockton requested a review from a team as a code owner May 20, 2025 18:33
@coveralls
Copy link

coveralls commented May 20, 2025

Pull Request Test Coverage Report for Build 15146315184

Details

  • 121 of 141 (85.82%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 70.15%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/mail.go 19 29 65.52%
internal/api/taskafter/taskafter.go 99 109 90.83%
Totals Coverage Status
Change from base Build 15141341085: 0.1%
Covered Lines: 11231
Relevant Lines: 16010

💛 - Coveralls

@cstockton
Copy link
Contributor Author

Some issues with this approach:

  • Wrapping the json response sending is very ugly and hard to prove correct
  • Invalid emails will still get signed up unless we call the validation code in mailer during tx
  • Likely want to be 100% async with some retries for mail sending for this change to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants