-
Notifications
You must be signed in to change notification settings - Fork 506
ci: improve go version management by using go.mod
#2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
….mod Additionally, remove unused strategy-matrix from test job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks a lot @avakarev
It failed because |
Pull Request Test Coverage Report for Build 15025666501Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
go.mod
Additionally, remove unused strategy-matrix from test job
What kind of change does this PR introduce?
Github workflow actions cleanup
What is the current behavior?
Job
actions/setup-go@v5
takes go version to install from the provided string literalWhat is the new behavior?
Job
actions/setup-go@v5
take go version fromgo.mod
Additional context
Now there are less things to maintain and less changes need to be done on go version bump.
Additionally, unused strategy-matrix from test job is removed.