Test Twitter OAuth implementation #1975
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD if these will be valuable. Its LLM generated. For discussion at weekly sync
Summary
This PR analyzes the Twitter OAuth provider implementation test coverage, finding that only 10.2% of statements and 75% of functions are covered. The coverage gap specifically affects the OAuth 1.0a authentication flow.
Key Findings
Covered: NewTwitterProvider, GetOAuthToken, GetUserData, newConsumer, Marshal, and Unmarshal
Uncovered Functions: FetchUserData and AuthCodeURL
Unit Tests (internal/api/provider/twitter_test.go)
Tests the provider's construction and utility methods
Integration Tests (internal/api/external_twitter_test.go)
Tests the complete authentication flow, but some skipped due to mocking complexity