test(completions): add test suite for more coverage #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
commented
Nov 8, 2025
juleswritescode
commented
Nov 8, 2025
..._completions/src/snapshots/pgls_completions__test_helper__prefers_not_mentioned_columns.snap
Show resolved
Hide resolved
…base-community/postgres_lsp into feat/completions-test-suite
…_lsp into feat/completions-test-suite
Collaborator
Author
|
@psteinroe finally reviewable – my local |
psteinroe
approved these changes
Nov 22, 2025
Collaborator
psteinroe
left a comment
psteinroe
left a comment
There was a problem hiding this comment.
this, my friend, is a work of art. 🎨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing every last variation of an SQL statement felt unmaintable, and it was annoying to work with the completions tests.
The new suite can be used to write large statements, check completions for every node, and to verify completion results more quickly.