use mvcc properties in compaction filter (tikv#8984)

Signed-off-by: qupeng <[email protected]>

components/engine_rocks/src/properties.rs

@@ -400,6 +400,7 @@ impl TablePropertiesCollectorFactory for RangePropertiesCollectorFactory {
     }
 }
 
+/// Can only be used for write CF.
 pub struct MvccPropertiesCollector {
     props: MvccProperties,
     last_row: Vec<u8>,
@@ -506,6 +507,7 @@ impl TablePropertiesCollector for MvccPropertiesCollector {
     }
 }
 
+/// Can only be used for write CF.
 #[derive(Default)]
 pub struct MvccPropertiesCollectorFactory {}
 

components/engine_rocks/src/table_properties.rs

@@ -9,7 +9,7 @@ use engine_traits::{
     TableProperties, TablePropertiesCollectionIter, TablePropertiesKey, UserCollectedProperties,
 };
 use engine_traits::{TablePropertiesCollection, TablePropertiesExt};
-use rocksdb::table_properties_rc as raw;
+use rocksdb::table_properties_rc as rc;
 use std::ops::Deref;
 
 impl TablePropertiesExt for RocksEngine {
@@ -35,10 +35,10 @@ impl TablePropertiesExt for RocksEngine {
     }
 }
 
-pub struct RocksTablePropertiesCollection(raw::TablePropertiesCollection);
+pub struct RocksTablePropertiesCollection(rc::TablePropertiesCollection);
 
 impl RocksTablePropertiesCollection {
-    fn from_raw(raw: raw::TablePropertiesCollection) -> RocksTablePropertiesCollection {
+    fn from_raw(raw: rc::TablePropertiesCollection) -> RocksTablePropertiesCollection {
         RocksTablePropertiesCollection(raw)
     }
 }
@@ -60,7 +60,7 @@ impl
     }
 }
 
-pub struct RocksTablePropertiesCollectionIter(raw::TablePropertiesCollectionIter);
+pub struct RocksTablePropertiesCollectionIter(rc::TablePropertiesCollectionIter);
 
 impl
     TablePropertiesCollectionIter<
@@ -81,7 +81,7 @@ impl Iterator for RocksTablePropertiesCollectionIter {
     }
 }
 
-pub struct RocksTablePropertiesKey(raw::TablePropertiesKey);
+pub struct RocksTablePropertiesKey(rc::TablePropertiesKey);
 
 impl TablePropertiesKey for RocksTablePropertiesKey {}
 
@@ -93,7 +93,7 @@ impl Deref for RocksTablePropertiesKey {
     }
 }
 
-pub struct RocksTableProperties(raw::TableProperties);
+pub struct RocksTableProperties(rc::TableProperties);
 
 impl TableProperties<RocksUserCollectedProperties> for RocksTableProperties {
     fn num_entries(&self) -> u64 {
@@ -105,7 +105,8 @@ impl TableProperties<RocksUserCollectedProperties> for RocksTableProperties {
     }
 }
 
-pub struct RocksUserCollectedProperties(raw::UserCollectedProperties);
+#[repr(transparent)]
+pub struct RocksUserCollectedProperties(rc::UserCollectedProperties);
 
 impl UserCollectedProperties for RocksUserCollectedProperties {
     fn get(&self, index: &[u8]) -> Option<&[u8]> {
@@ -123,3 +124,13 @@ impl DecodeProperties for RocksUserCollectedProperties {
             .ok_or(tikv_util::codec::Error::KeyNotFound)
     }
 }
+
+#[repr(transparent)]
+pub struct RocksUserCollectedPropertiesNoRc(rocksdb::UserCollectedProperties);
+impl DecodeProperties for RocksUserCollectedPropertiesNoRc {
+    fn decode(&self, k: &str) -> tikv_util::codec::Result<&[u8]> {
+        self.0
+            .get(k.as_bytes())
+            .ok_or(tikv_util::codec::Error::KeyNotFound)
+    }
+}

components/engine_traits/src/mvcc_properties.rs

@@ -3,7 +3,7 @@
 use std::cmp;
 use txn_types::TimeStamp;
 
-#[derive(Clone, Debug, Default)]
+#[derive(Clone, Debug)]
 pub struct MvccProperties {
     pub min_ts: TimeStamp,     // The minimal timestamp.
     pub max_ts: TimeStamp,     // The maximal timestamp.