Skip to content

Commit

Permalink
raftstore: make apply log and read process more early (tikv#8662)
Browse files Browse the repository at this point in the history
Signed-off-by: gengliqi <[email protected]>
  • Loading branch information
gengliqi authored Oct 17, 2020
1 parent a718814 commit 482bd12
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 17 deletions.
5 changes: 4 additions & 1 deletion components/raftstore/src/store/fsm/peer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -861,12 +861,15 @@ where
self.ctx.pending_count += 1;
self.ctx.has_ready = true;
let res = self.fsm.peer.handle_raft_ready_append(self.ctx);
if let Some(r) = res {
if let Some(mut r) = res {
self.on_role_changed(&r.0);
if !r.0.entries().is_empty() {
self.register_raft_gc_log_tick();
self.register_split_region_check_tick();
}
if self.ctx.cfg.early_apply {
self.handle_raft_ready_apply(&mut r.0, &r.1);
}
self.ctx.ready_res.push(r);
}
}
Expand Down
16 changes: 0 additions & 16 deletions components/raftstore/src/store/fsm/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -639,22 +639,6 @@ impl<EK: KvEngine, ER: RaftEngine, T: Transport, C: PdClient> RaftPoller<EK, ER,
self.poll_ctx.need_flush_trans = false;
}
let ready_cnt = self.poll_ctx.ready_res.len();
if ready_cnt != 0 && self.poll_ctx.cfg.early_apply {
let mut batch_pos = 0;
let mut ready_res = mem::replace(&mut self.poll_ctx.ready_res, vec![]);
for (ready, invoke_ctx) in &mut ready_res {
let region_id = invoke_ctx.region_id;
if peers[batch_pos].region_id() == region_id {
} else {
while peers[batch_pos].region_id() != region_id {
batch_pos += 1;
}
}
PeerFsmDelegate::new(&mut peers[batch_pos], &mut self.poll_ctx)
.handle_raft_ready_apply(ready, invoke_ctx);
}
self.poll_ctx.ready_res = ready_res;
}
self.poll_ctx.raft_metrics.ready.has_ready_region += ready_cnt as u64;
fail_point!("raft_before_save");
if !self.poll_ctx.kv_wb.is_empty() {
Expand Down

0 comments on commit 482bd12

Please sign in to comment.