Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 98.66% 98.67%
=======================================
Files 27 27
Lines 902 908 +6
=======================================
+ Hits 890 896 +6
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haxoza
approved these changes
Aug 11, 2025
Member
haxoza
left a comment
haxoza
left a comment
There was a problem hiding this comment.
Overall looks good, just some minor comments.
| response = self._get_view_response(request, provider="facebook") | ||
| assert response.status_code == status.HTTP_400_BAD_REQUEST | ||
|
|
||
| def test_post_facebook_provider_auth_unknown_error(self): |
Member
There was a problem hiding this comment.
looks like the code for all 3 tests is the same, I would do a test generator or anything to decrease the amount of test code to read / maintain
| request = self.factory.post("/auth/facebook/") | ||
| request.GET = data | ||
| response = self._get_view_response(request, provider="facebook") | ||
| assert response.status_code == status.HTTP_400_BAD_REQUEST |
| self.signal_sent = False | ||
| self.base_url = reverse("login") | ||
| @pytest.mark.django_db | ||
| class TestTokenCreateView: |
Member
There was a problem hiding this comment.
I'm not sure why there is some inconsistency when it comes to grouping tests in classes like here, or not like in e.g. test_password_reset.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.