Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor and upgrade services definition to remove deprecated notices #109

Closed
wants to merge 4 commits into from
Closed

Conversation

fdespier
Copy link
Contributor

@fdespier fdespier commented Jun 9, 2017

Hi all,

  • Update composer to use Symfony 3.3
  • Upgrade Service definition
    • XML files are deprecated in SF 3.4 (and remove in 4.0)
    • Use Classname instead alias
    • use autowire when it's possible
    • Remove class parameters (unused method since SF 2.7)
  • Upgrade autoload to PSR-4 (PSR-0 is deprecated)
  • Fix checkstyle with Symfony2 rules
  • Twig extension : getName method is now deprecated

best,

@xabbuh
Copy link
Contributor

xabbuh commented Jun 10, 2017

Using XML files to configure your services is not deprecated and will still work in Symfony 4.

@fdespier
Copy link
Contributor Author

@xabbuh My bad, an issue was open on this topic and you're right (symfony/symfony#22870) .

XML format is'nt deprecated but not the mainstream method to define services.

@fdespier fdespier changed the title Refactor and upgrade services definition to remove deprecated notices [Wip] Refactor and upgrade services definition to remove deprecated notices Jun 13, 2017
@fdespier fdespier changed the title [Wip] Refactor and upgrade services definition to remove deprecated notices [WIP] Refactor and upgrade services definition to remove deprecated notices Jun 13, 2017
@fdespier
Copy link
Contributor Author

fdespier commented Jul 7, 2017

Hi all,

I think, it will be better to refactor the service declaration of this bundle in an other branch (2.X) to prevent BC break.

@suncat2000 could you answer to my issue #115 ?

best,

@fdespier fdespier closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants