Repository navigation
馃悰(frontend) switch language when the current one is untranslated - #2790
Merged
Merged
Conversation
AntoLC
force-pushed
the
fix/language-picker-untranslated
branch
from
October 7, 2026 13:14
f675517 to
d0d7525
Compare
Contributor
|
Size Change: 0 B Total Size: 4.06 MB 馃摝 View Changed
|
AntoLC
force-pushed
the
fix/language-picker-untranslated
branch
from
October 13, 2026 06:51
d0d7525 to
d4402f8
Compare
With zh-tw active, selecting English did nothing: its bundle is empty, so i18next reports `resolvedLanguage` as en while `language` is zh-tw, and the hook skipped the change. Compare with `language` instead, and add unit tests on the language pickers.
AntoLC
force-pushed
the
fix/language-picker-untranslated
branch
from
October 13, 2026 06:56
d4402f8 to
c5f97ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
With zh-tw as the current language, selecting English in the language picker did nothing. The zh-tw bundle is still empty, so i18next reports
resolvedLanguageasenwhilelanguageiszh-tw, and the synchronization hook took the interface for already being in English.Proposal
i18n.languageinstead ofresolvedLanguageinuseSynchronizedLanguageLanguagePickerandLanguagePickerLegacy(single selection, switch from zh-tw to English)Demo problem