Skip to content

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Dec 17, 2025

Purpose

Improve keyboard accessibility when opening the emoji picker
by focusing the input field automatically. Also fix keyboard interaction with
subdocuments using the Enter key.

Proposal

Automatically place focus on the search input when the emoji picker opens.
Additionally, ensure that pressing Enter correctly selects subdocuments,
improving keyboard usability.

  • Focus emoji picker input on open
  • Fix Enter key handling on subdocuments

@Ovgodd Ovgodd requested a review from AntoLC December 17, 2025 13:58
@Ovgodd Ovgodd self-assigned this Dec 17, 2025
@Ovgodd Ovgodd force-pushed the fix/a11y-emoji-picker-focus-and-enter branch from 70177ca to 7c90e7f Compare December 17, 2025 13:59
@Ovgodd Ovgodd marked this pull request as ready for review December 17, 2025 13:59
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Size Change: +291 B (+0.01%)

Total Size: 4.16 MB

Filename Size Change
apps/impress/out/_next/static/5f930865/_buildManifest.js 0 B -889 B (removed) 🏆
apps/impress/out/_next/static/893b3803/_buildManifest.js 889 B +889 B (new file) 🆕

compressed-size-action

Comment on lines +113 to +120
useKeyboardActivation(
['Enter'],
isActive && !menuOpen,
handleActivate,
true,
'.c__tree-view',
);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need it anymore, this commit (suitenumerique/ui-kit@c121fdd#diff-69b4765cf5a180b5d5c2157eb0132487a6c0b7b7fb1dc379250ce110ac162e2eR27) adds onKeyDown, so here you can add directly what you need now.
You have to bump to the last ui-kit version though.

Copy link
Collaborator Author

@Ovgodd Ovgodd Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has talk together, waiting for updates on your side because change @gouvfr-lasuite/ui-kit": "0.18.4" to .5 or .6 seems to break

@Ovgodd Ovgodd force-pushed the fix/a11y-emoji-picker-focus-and-enter branch 3 times, most recently from 1955c20 to 5e197f3 Compare January 9, 2026 08:42
@socket-security
Copy link

socket-security bot commented Jan 9, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm vite is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@Ovgodd Ovgodd force-pushed the fix/a11y-emoji-picker-focus-and-enter branch from 5e197f3 to 2560f59 Compare January 9, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants