-
Notifications
You must be signed in to change notification settings - Fork 503
♿️(frontend) fix subdoc opening and emoji pick focus #1745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
70177ca to
7c90e7f
Compare
|
Size Change: +291 B (+0.01%) Total Size: 4.16 MB
|
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Outdated
Show resolved
Hide resolved
| useKeyboardActivation( | ||
| ['Enter'], | ||
| isActive && !menuOpen, | ||
| handleActivate, | ||
| true, | ||
| '.c__tree-view', | ||
| ); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need it anymore, this commit (suitenumerique/ui-kit@c121fdd#diff-69b4765cf5a180b5d5c2157eb0132487a6c0b7b7fb1dc379250ce110ac162e2eR27) adds onKeyDown, so here you can add directly what you need now.
You have to bump to the last ui-kit version though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has talk together, waiting for updates on your side because change @gouvfr-lasuite/ui-kit": "0.18.4" to .5 or .6 seems to break
1955c20 to
5e197f3
Compare
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
ensures subdoc opens and emoji picker focus on input Signed-off-by: Cyril <[email protected]>
ensures subdoc opens and emoji picker focus on input Signed-off-by: Cyril <[email protected]>
5e197f3 to
2560f59
Compare
Purpose
Improve keyboard accessibility when opening the emoji picker
by focusing the input field automatically. Also fix keyboard interaction with
subdocuments using the Enter key.
Proposal
Automatically place focus on the search input when the emoji picker opens.
Additionally, ensure that pressing Enter correctly selects subdocuments,
improving keyboard usability.