Skip to content

feat: support rendering HTML tags in markdown content #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irisWirisW wants to merge 1 commit into
base: main
Choose a base branch
from
+73 −27
Open

feat: support rendering HTML tags in markdown content #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions SwiftCraftLauncher.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

/* Begin PBXBuildFile section */
030C47462E7F82E700A209A8 /* SkinRenderKit in Frameworks */ = {isa = PBXBuildFile; productRef = 030C47452E7F82E700A209A8 /* SkinRenderKit */; };
03C64DD52F0068A000D26B06 /* MarkdownView in Frameworks */ = {isa = PBXBuildFile; productRef = 03C64DD42F0068A000D26B06 /* MarkdownView */; };
9023D91C2E313A67005A53F1 /* ZIPFoundation in Frameworks */ = {isa = PBXBuildFile; productRef = 9023D91B2E313A67005A53F1 /* ZIPFoundation */; };
906099592EED2CE400C7DCA5 /* MarkdownUI in Frameworks */ = {isa = PBXBuildFile; productRef = 906099582EED2CE400C7DCA5 /* MarkdownUI */; };
90E123456789ABCD0001 /* Sparkle in Frameworks */ = {isa = PBXBuildFile; productRef = 90E123456789ABCD0002 /* Sparkle */; };
/* End PBXBuildFile section */

Expand All @@ -33,7 +33,7 @@
9023D91C2E313A67005A53F1 /* ZIPFoundation in Frameworks */,
030C47462E7F82E700A209A8 /* SkinRenderKit in Frameworks */,
90E123456789ABCD0001 /* Sparkle in Frameworks */,
906099592EED2CE400C7DCA5 /* MarkdownUI in Frameworks */,
03C64DD52F0068A000D26B06 /* MarkdownView in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -72,7 +72,7 @@
9023D91B2E313A67005A53F1 /* ZIPFoundation */,
90E123456789ABCD0002 /* Sparkle */,
030C47452E7F82E700A209A8 /* SkinRenderKit */,
906099582EED2CE400C7DCA5 /* MarkdownUI */,
03C64DD42F0068A000D26B06 /* MarkdownView */,
);
productName = SwiftCraftLauncher;
productReference = 90CE44FE2E7D65A5007C6F30 /* Swift Craft Launcher.app */;
Expand Down Expand Up @@ -109,7 +109,7 @@
90E123456789ABCD0003 /* XCRemoteSwiftPackageReference "Sparkle" */,
033870FA2E6059570056BDB2 /* XCRemoteSwiftPackageReference "SwiftLintPlugins" */,
030C47442E7F82E700A209A8 /* XCRemoteSwiftPackageReference "NSSkinRender" */,
906099572EED2CE400C7DCA5 /* XCRemoteSwiftPackageReference "swift-markdown-ui" */,
03C64DD32F0068A000D26B06 /* XCRemoteSwiftPackageReference "MarkdownView" */,
);
preferredProjectObjectVersion = 77;
productRefGroup = 9023D8282E3139B5005A53F1;
Expand Down Expand Up @@ -383,20 +383,20 @@
minimumVersion = 0.59.1;
};
};
9023D91A2E313A67005A53F1 /* XCRemoteSwiftPackageReference "ZIPFoundation" */ = {
03C64DD32F0068A000D26B06 /* XCRemoteSwiftPackageReference "MarkdownView" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/weichsel/ZIPFoundation.git";
repositoryURL = "https://github.com/LiYanan2004/MarkdownView";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 0.9.19;
branch = mdv3;
kind = branch;
};
};
906099572EED2CE400C7DCA5 /* XCRemoteSwiftPackageReference "swift-markdown-ui" */ = {
9023D91A2E313A67005A53F1 /* XCRemoteSwiftPackageReference "ZIPFoundation" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/gonzalezreal/swift-markdown-ui.git";
repositoryURL = "https://github.com/weichsel/ZIPFoundation.git";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 2.4.1;
minimumVersion = 0.9.19;
};
};
90E123456789ABCD0003 /* XCRemoteSwiftPackageReference "Sparkle" */ = {
Expand All @@ -420,16 +420,16 @@
package = 033870FA2E6059570056BDB2 /* XCRemoteSwiftPackageReference "SwiftLintPlugins" */;
productName = "plugin:SwiftLintBuildToolPlugin";
};
03C64DD42F0068A000D26B06 /* MarkdownView */ = {
isa = XCSwiftPackageProductDependency;
package = 03C64DD32F0068A000D26B06 /* XCRemoteSwiftPackageReference "MarkdownView" */;
productName = MarkdownView;
};
9023D91B2E313A67005A53F1 /* ZIPFoundation */ = {
isa = XCSwiftPackageProductDependency;
package = 9023D91A2E313A67005A53F1 /* XCRemoteSwiftPackageReference "ZIPFoundation" */;
productName = ZIPFoundation;
};
906099582EED2CE400C7DCA5 /* MarkdownUI */ = {
isa = XCSwiftPackageProductDependency;
package = 906099572EED2CE400C7DCA5 /* XCRemoteSwiftPackageReference "swift-markdown-ui" */;
productName = MarkdownUI;
};
90E123456789ABCD0002 /* Sparkle */ = {
isa = XCSwiftPackageProductDependency;
package = 90E123456789ABCD0003 /* XCRemoteSwiftPackageReference "Sparkle" */;
Expand Down
63 changes: 54 additions & 9 deletions SwiftCraftLauncher.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions SwiftCraftLauncher/Views/ModrinthProjectDetail/ModrinthProjectDetailView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import MarkdownUI
import MarkdownView
import SwiftUI

// MARK: - Constants
Expand Down Expand Up @@ -114,7 +114,8 @@ struct ModrinthProjectDetailView: View {
}

private func descriptionView(_ project: ModrinthProjectDetail) -> some View {
Markdown(project.body)
// Markdown(project.body)
MarkdownView(project.body)
// EmptyView()
}

Expand Down