-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: atrium-repo
#272
feat: atrium-repo
#272
Conversation
3b84377
to
f8e988e
Compare
f736ccc
to
b230066
Compare
6db3530
to
60adc4a
Compare
I think the PR is in a pretty good state for a MVP. |
Pinging @str4d since this builds on their prior work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have written several comments on areas unrelated to the internal logic. There are also a couple of points from clippy that I hope you can correct as well.
5f55fc5
to
cb8e8c0
Compare
Note: It looks like there's a pretty exhaustive MST test suite here that could probably be leveraged to validate this implementation. |
b3afd8a
to
2ee7cba
Compare
9277356
to
465724d
Compare
Thank you! And I'm sure there are some bugs in the implementation - I'm hoping that someone else will shake them out if I don't get around to it :) |
This builds on str4d's work here: #168.
Big notes:
Repository
implementation with support for basic CRUD operationsAsyncBlockStoreRead
andAsyncBlockStoreWrite
.Test coverage (

cargo llvm-cov -p atrium-repo --html --open
):Node
Node
from bytesTreeEntry
s perNode
to a statistically unlikely maximum length.