Skip to content

Initialize DecoderBase when fetching Default Decoders #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initialize DecoderBase when fetching Default Decoders #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion decoder/bpe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func NewBpeDecoder(suffix string) *BpeDecoder {

// DefaultBpeDecoder create a new BpeDecoder with default suffix (`</w>`)
func DefaultBpeDecoder() *BpeDecoder {
return &BpeDecoder{suffix: "</w>"}
return NewBpeDecoder("</w>")
}

/*
Expand Down
7 changes: 2 additions & 5 deletions decoder/wordpiece.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,9 @@ func NewWordPieceDecoder(prefix string, cleanup bool) *WordPieceDecoder {
return d
}

// DefaultBpeDecoder create a new BpeDecoder with default suffix (`</w>`)
// DefaultWordpieceDecoder creates a new WordPieceDecoder with default prefix (`##`)
func DefaultWordpieceDecoder() *WordPieceDecoder {
return &WordPieceDecoder{
prefix: "##",
cleanup: true,
}
return NewWordPieceDecoder("##", true)
}

/*
Expand Down