Float Donation Button to Enhance Banner Visibility #612
+142
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed. Does seem a lot of complexity for something so simple, but I guess we'll always have a donate button. Acceptable commit message, as if you lacked the time to write anything better, but then you go and write a huge pull request opening comment; much of that text really should be in the commit message. |
Merged
|
Hopefully, the new commit message meets the expectations :) |
|
Yes, thanks. |
- Adds a floating donation button to maintain visibility when the main banner is not in view. - Appears when users scroll down or close the banner.
|
@pikurasa |
|
I think it's a good idea, I tested it, and thanks for putting custom css in its proper place. |
|
Glad it worked :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A floating button for the donation banner to ensure visibility when the current banner is not visible or partially obscured.
Purpose
SugarLabs aims to raise $25K by this fall, and the current donation banner is visually effective. However, if a user closes the banner or scrolls down, the banner becomes hidden. This is particularly noticeable on mobile devices, where the site's "Donate" button is located within the hamburger menu, making it less accessible.
To address this, I have implemented a floating donation button. This button becomes visible when the user scrolls down and the current banner is no longer in view or when the user closes the banner. It ensures a persistent and accessible way to encourage donations at all times.
Screenshot