test: introduce structured test infrastructure and refactor palette tests for deterministic CI#6368
Open
mahesh-09-12 wants to merge 4 commits intosugarlabs:masterfrom
Open
Conversation
- add reusable test utilities - centralize test setup
- enable setupFilesAfterEnv - use clearMocks and restoreMocks
- replace inline mocks - improve DOM handling
- use jest.spyOn instead of implicit mock
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
Hi @walterbender @omsuneri , I've opened a PR introducing test infrastructure improvements and palette test refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a structured test infrastructure and refactors palette tests to improve reliability, isolation, and determinism.
The goal is to reduce flaky behavior caused by implicit globals, shared state, and loosely mocked DOM interactions — which are known issues in the current codebase and CI.
What’s Changed
1. Test Infrastructure
setupTests.js)2. Jest Configuration
setupFilesAfterEnvfor consistent test initializationrestoreMocksresetMocks(as it breaks required mock implementations)3. Palette Test Refactor
palette.test.jsto use shared utilities4. Fix: Implicit Mock Dependency
trash.test.jswhich relied on a leaked global mock ofwindow.addEventListenerjest.spyOnto ensure compatibility with restored mocksWhy This Matters
Previously:
Now:
This lays the foundation for:
Coverage Note
There is a minor drop (~1%) in functional coverage.
This is expected because:
No test cases were removed, and overall test reliability has improved.
PR Category