Fix ReferenceError: _ is not defined on page load#6367
Open
gcharpe1604 wants to merge 1 commit intosugarlabs:masterfrom
Open
Fix ReferenceError: _ is not defined on page load#6367gcharpe1604 wants to merge 1 commit intosugarlabs:masterfrom
gcharpe1604 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
f21767e to
997d4b1
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the
ReferenceError: _ is not definedthat occurs during the initial loading of MusicBlocks. The error was caused by a race condition where some components attempted to use the translation function_before it was fully loaded and defined.Related Issue
Fixes #6365
PR Category
Changes Made
Testing Performed
Checklist