Skip to content

Fix invalid markup and manifest files#6366

Open
Sidharthwin wants to merge 1 commit intosugarlabs:masterfrom
Sidharthwin:fix-invalid-markup-and-manifest-files
Open

Fix invalid markup and manifest files#6366
Sidharthwin wants to merge 1 commit intosugarlabs:masterfrom
Sidharthwin:fix-invalid-markup-and-manifest-files

Conversation

@Sidharthwin
Copy link

@Sidharthwin Sidharthwin commented Mar 23, 2026

Closes #6364

Description

While reviewing the repository, I noticed a few syntax issues in different files that were causing validation/formatter errors. These were not formatting-related, but actual HTML/JSON inconsistencies.

This PR fixes those issues to ensure proper syntax and improve overall code quality.


Changes Made

  • Fixed invalid JSON in manifest.webapp

    • Removed incorrect closing brace and adjusted commas to ensure valid JSON structure.
  • Resolved duplicate closing tag in planet/index.html

    • Removed extra </li> tag that was causing invalid HTML.
  • Removed stray closing tag in Docs/guide-es/index.html

    • Deleted an unmatched </p> tag that was breaking the HTML structure.
  • Corrected table structure in Docs/guide-pt/index.html

    • Wrapped <td> elements inside a proper <tr> to maintain valid table hierarchy.
  • Ensured proper HTML document structure

    • Fixed closing tags where necessary to maintain well-formed HTML.

Impact

  • Prevents formatter/linting failures
  • Ensures valid HTML and JSON syntax
  • Improves maintainability and consistency across the codebase

Notes

All changes were kept minimal and focused only on fixing syntax issues without altering functionality.


  • Bug Fix

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@github-actions github-actions bot added bug fix Fixes a bug or incorrect behavior size/XS Extra small: < 10 lines changed area/docs Changes to documentation labels Mar 23, 2026
@Sidharthwin
Copy link
Author

Hi, @Ashutoshx7 , @vyagh and @omsuneri pls check I’ve fixed the identified syntax issues and verified the changes locally.
Please let me know if any improvements or changes are needed.

Copy link
Contributor

@mahesh-09-12 mahesh-09-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidharthwin nice cleanup, fixing invalid HTML/JSON is definitely useful, since some of these changes touch structure (like table rows and closing tags), did you verify there’s no visible impact on rendering (especially in the docs pages)? also, was this validated with any HTML/JSON validator or just manual fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Changes to documentation bug fix Fixes a bug or incorrect behavior size/XS Extra small: < 10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve invalid markup and JSON issues in multiple files

2 participants