Fix invalid markup and manifest files#6366
Open
Sidharthwin wants to merge 1 commit intosugarlabs:masterfrom
Open
Fix invalid markup and manifest files#6366Sidharthwin wants to merge 1 commit intosugarlabs:masterfrom
Sidharthwin wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Author
|
Hi, @Ashutoshx7 , @vyagh and @omsuneri pls check I’ve fixed the identified syntax issues and verified the changes locally. |
Contributor
mahesh-09-12
left a comment
There was a problem hiding this comment.
@Sidharthwin nice cleanup, fixing invalid HTML/JSON is definitely useful, since some of these changes touch structure (like table rows and closing tags), did you verify there’s no visible impact on rendering (especially in the docs pages)? also, was this validated with any HTML/JSON validator or just manual fixes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6364
Description
While reviewing the repository, I noticed a few syntax issues in different files that were causing validation/formatter errors. These were not formatting-related, but actual HTML/JSON inconsistencies.
This PR fixes those issues to ensure proper syntax and improve overall code quality.
Changes Made
Fixed invalid JSON in
manifest.webappResolved duplicate closing tag in
planet/index.html</li>tag that was causing invalid HTML.Removed stray closing tag in
Docs/guide-es/index.html</p>tag that was breaking the HTML structure.Corrected table structure in
Docs/guide-pt/index.html<td>elements inside a proper<tr>to maintain valid table hierarchy.Ensured proper HTML document structure
Impact
Notes
All changes were kept minimal and focused only on fixing syntax issues without altering functionality.