helpful Search only visible in advance mode #4203
Conversation
There was a problem hiding this comment.
As I said, I am still able to re-create the issue. I have used docker for testing. Also what you have done in Line 503 is the same condition from line 460 and essentially adding line inside 455-457 seems pointless because we have essentially removed a condition and added it again somewhere else .
| // Add event listener to remove the search div from the DOM | ||
| const modeButton = docById("begIconText"); | ||
| closeButton.addEventListener("click", this._hideHelpfulSearchWidget); | ||
| modeButton.addEventListener("click", this._hideHelpfulSearchWidget); |
There was a problem hiding this comment.
what does this even accomplish? I assume the solution is due to the missing condition from L503
| @@ -498,6 +498,9 @@ class Activity { | |||
| if (docById("helpfulWheelDiv").style.display !== "none") { | |||
| docById("helpfulWheelDiv").style.display = "none"; | |||
| } | |||
| if (this.helpfulSearchDiv && this.helpfulSearchDiv.parentNode) { | |||
There was a problem hiding this comment.
this makes sense but I am still able to recreate the issue in my local system.
|
Yes, condition of Line 460 to 464 and Line 496 this two are same. Updated in this commit |
|
@walterbender Sir, is this okay ? |
|
Prob. we should only have one search open at a time. |
That's mean if we open the master branch searchbar the helpful search should be hide ? |
|
and vice versa |
Yes Sir done. Please check |
resolve #4202
The helpful search option is now only visible in advance mode
Screen.Recording.2024-12-29.014923.mp4