-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test File for the API #4201
Test File for the API #4201
Conversation
@walterbender check this out i had started some new tests as we decided in last meet |
The tests look good, would love to collaborate on the remaining API files, I have written some tests for VolumeBlocksAPI as of now. |
@BeNikk love to see your contribution |
indeed the tests look good i would also like to contribute to the same i have created the test for the rest of the files too in the Api section |
@justin212407 just wait for sometime as soon as this merged then look forward to your contribution too |
sure i mean otherwise it might get some conflicts with two test folders |
@justin212407 yeah you got it right |
@omsuneri sure i will wait to create a pull request on the same. I just wanted to inform you so that you could start working on other tests too. |
Yaa I had also created 3 more tests will update in this branch so they all got merged at a time |
Yes, @justin212407 I am adding the tests for pitchblocksAPI and am done with volumeblocksAPI and rhythmblocksAPI, you can write tests for the remaining files |
I had done pitch.. volume... Ornam.. and graphics |
I have already written those too @BeNikk |
You guyss can do other than these |
Not sure why, but I am encountering a problem with https://registry.npmjs.org/jest-evironment-jsdom |
@walterbender you are getting jsdom dependency issue |
@walterbender i had tested it again using npm test and all of them works absolutely fine |
I think js-dom needs a separate install, it worked fine for me too |
For some reason, I am getting lots of errors trying to install js-dom |
@walterbender I m unsure why this happens to you but I don't edit any of the dependencies |
@walterbender can you share snapshot what you are getting on npm test |
not sure what was scrambled, but a rebase sorted things out. |
@walterbender ohh fine I was just searching why this is happening 😅 |
Test file runs perfectly for the #4200
DictBlocksAPI.js
MeterBlocksAPI.js
PenBlocksAPI.js
IntervalsBlocksAPI.js
ToneBlocksAPI.js
PitchBlocksAPI.js