Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test File for the API #4201

Merged
merged 11 commits into from
Dec 29, 2024
Merged

Conversation

omsuneri
Copy link
Contributor

@omsuneri omsuneri commented Dec 28, 2024

Test file runs perfectly for the #4200
DictBlocksAPI.js
MeterBlocksAPI.js
PenBlocksAPI.js
IntervalsBlocksAPI.js
ToneBlocksAPI.js
PitchBlocksAPI.js
Screenshot 2024-12-29 at 2 27 04 PM

@omsuneri
Copy link
Contributor Author

@walterbender check this out i had started some new tests as we decided in last meet

@omsuneri omsuneri changed the title Test File for the DictBlocksAPI Test File for the API Dec 29, 2024
@BeNikk
Copy link
Contributor

BeNikk commented Dec 29, 2024

The tests look good, would love to collaborate on the remaining API files, I have written some tests for VolumeBlocksAPI as of now.

@omsuneri
Copy link
Contributor Author

@BeNikk love to see your contribution

@justin212407
Copy link
Contributor

indeed the tests look good i would also like to contribute to the same i have created the test for the rest of the files too in the Api section

@omsuneri
Copy link
Contributor Author

@justin212407 just wait for sometime as soon as this merged then look forward to your contribution too

@justin212407
Copy link
Contributor

sure i mean otherwise it might get some conflicts with two test folders

@omsuneri
Copy link
Contributor Author

@justin212407 yeah you got it right

@justin212407
Copy link
Contributor

@omsuneri sure i will wait to create a pull request on the same. I just wanted to inform you so that you could start working on other tests too.

@omsuneri
Copy link
Contributor Author

Yaa I had also created 3 more tests will update in this branch so they all got merged at a time

@BeNikk
Copy link
Contributor

BeNikk commented Dec 29, 2024

Yes, @justin212407 I am adding the tests for pitchblocksAPI and am done with volumeblocksAPI and rhythmblocksAPI, you can write tests for the remaining files

@omsuneri
Copy link
Contributor Author

I had done pitch.. volume... Ornam.. and graphics

@justin212407
Copy link
Contributor

I have already written those too @BeNikk

@omsuneri
Copy link
Contributor Author

You guyss can do other than these

@walterbender
Copy link
Member

Not sure why, but I am encountering a problem with https://registry.npmjs.org/jest-evironment-jsdom

@omsuneri
Copy link
Contributor Author

@walterbender you are getting jsdom dependency issue

@omsuneri
Copy link
Contributor Author

@walterbender i had tested it again using npm test and all of them works absolutely fine
Screenshot 2024-12-29 at 9 19 13 PM

@BeNikk
Copy link
Contributor

BeNikk commented Dec 29, 2024

I think js-dom needs a separate install, it worked fine for me too

@walterbender
Copy link
Member

For some reason, I am getting lots of errors trying to install js-dom

@omsuneri
Copy link
Contributor Author

@walterbender I m unsure why this happens to you but I don't edit any of the dependencies

@omsuneri
Copy link
Contributor Author

@walterbender can you share snapshot what you are getting on npm test

@walterbender walterbender merged commit a65a865 into sugarlabs:master Dec 29, 2024
4 checks passed
@walterbender
Copy link
Member

not sure what was scrambled, but a rebase sorted things out.

@omsuneri
Copy link
Contributor Author

@walterbender ohh fine I was just searching why this is happening 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants